chore: enable tokio macros and rt features#67
Open
bkfunk wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Enables additional tokio features (macros and rt) at the workspace level so downstream consumers and in-tree tests can use #[tokio::test] without redeclaring tokio with extra features. No production code paths are affected since unused tokio features are gated.
Changes:
- Add
macrosandrtto the workspacetokiofeature list inCargo.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workspace-level
tokiodependency currently enables only theio-utilfeature. This is sufficient for the library code paths, but consumers that want to write#[tokio::test]-style tests against these crates have to add their owntokiodependency withmacrosandrtfeatures to make the attribute macros and runtime available.Adding
macrosandrtto the workspacetokiofeatures is a no-op for production code paths (those features are gated on use) but unblocks#[tokio::test]in downstream consumers and in any in-tree tests.Change
Test plan
cargo check --workspacepasses